- From: Simon Pieters <notifications@github.com>
- Date: Wed, 22 Apr 2026 06:58:26 -0700
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 22 April 2026 13:58:30 UTC
zcorpan left a comment (whatwg/fullscreen#232) In https://github.com/whatwg/fullscreen/pull/232/commits/f4149b1c6a26917a0c472f64f149c52f17cc0e05 I changed what happens when keyboard lock is not supported (by the platform or for security reasons etc); instead of rejecting with `NotSupportedError` it follows the same steps as other error cases (so no transient activation is consumed, a `fullscreenerror` event is fired, and rejects with `TypeError`. However maybe it should still successfully fullscreen in this case, just without keyboard lock. We can add `document.keyboardLockEnabled` and `document.keyboardLock` to mirror `document.fullscreenEnabled` and `document.fullscreen`, so it's easy to tell if it will be possible to acquire keyboard lock and whether it's currently active. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fullscreen/pull/232?email_source=notifications&email_token=ACLYVMMTG6ACOPFEXWSBEP34XDFYFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRZGY4DAOJZGY22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS2XA4S7MNXW23LFNZ2F633QMVXF6Y3MNFRWW#issuecomment-4296809965 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fullscreen/pull/232/c4296809965@github.com>
Received on Wednesday, 22 April 2026 13:58:30 UTC