Re: [w3c/manifest] Clarify how manifest image resources are fetched (PR #1171)

@Copilot commented on this pull request.

## Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.





---

💡 <a href="/w3c/manifest/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.

> +        resource=] |image| and an [=application manifest=] |manifest|:
+      </p>
+      <ol class="algorithm">
+        <li>If |manifest|'s [=application manifest/client=] is null, return null.

`fetch a manifest image resource` returns `null` when `manifest`’s client is null, but the algorithm never defines its return type or what `null` means to callers. Elsewhere in this spec, algorithms typically return `failure`/a value rather than `null`. Consider either (a) returning `failure` (and describing how callers should handle it), or (b) normatively stating the return type up front (e.g., response/image-or-null) and specifying the required behavior when `null` is returned.
```suggestion
        resource=] |image| and an [=application manifest=] |manifest|, return
        either the result of [=fetching an image resource=] or null:
      </p>
      <ol class="algorithm">
        <li>If |manifest|'s [=application manifest/client=] is null, return
        null.
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1171#pullrequestreview-4104580068
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/pull/1171/review/4104580068@github.com>