Re: [w3c/manifest] Clarify how manifest image resources are fetched (PR #1171)

@Copilot commented on this pull request.

## Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.





---

💡 <a href="/w3c/manifest/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.

> @@ -1681,6 +1682,8 @@ <h3>
             any proprietary and/or other supported members at this point in the
             algorithm.
             </li>
+            <li>Set |manifest|'s <dfn data-dfn-for="application manifest">client</dfn> to |client|.
+            </li>

The algorithm stores the new application manifest/client value *after* the processing extension-point, which prevents extension specs from accessing the client during their hook (e.g., if they need CSP/service-worker-aware fetches). Consider setting the manifest’s client immediately after creating |manifest| (or otherwise making |client| available to the extension-point) so extensions can rely on it consistently.

> +        <li>If |manifest|'s [=application manifest/client=] is null, return.
+        </li>
+        <li>Let |request| be a new [=request=].
+        </li>
+        <li>Set |request|'s [=request/URL=] to |image|'s {{ImageResource/src}}.
+        </li>
+        <li>Set |request|'s [=request/destination=] to "`image`".
+        </li>
+        <li>Set |request|'s [=request/client=] to |manifest|'s [=application
+        manifest/client=].
+        </li>

Returning early when application manifest/client is null makes the fetch a manifest image resource algorithm a no-op for manifests processed without a document (where this PR says client is null), which would prevent icons/shortcut icons from being fetched in that scenario. Instead, still create the request and run fetching an image resource, leaving request/client as null (or define an explicit fallback client) so image fetching still works even when CSP/SW interception can’t apply.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1171#pullrequestreview-4096507619
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/pull/1171/review/4096507619@github.com>