Re: [whatwg/fetch] [WebDriver BiDi] emulate `user-agent` string (PR #1851)

@annevk commented on this pull request.



> +    <p>If <var>httpRequest</var>'s <a for=request>header list</a> <a for="header list">does not
+    contain</a> `<code>User-Agent</code>`, then:

```suggestion
    <p>If <var>httpRequest</var>'s <a for=request>header list</a> <a for="header list">does not
    contain</a> `<code>User-Agent</code>`:
```

> @@ -5889,11 +5889,20 @@ run these steps:
    the <a data-lt="structured field token">token</a> <code>prefetch</code>) in
    <var>httpRequest</var>'s <a for=request>header list</a>.
 
-   <li><p>If <var>httpRequest</var>'s <a for=request>header list</a>
-   <a for="header list">does not contain</a> `<code>User-Agent</code>`, then user agents should
-   <a for="header list">append</a> (`<code>User-Agent</code>`,
-   <a>default `<code>User-Agent</code>` value</a>) to <var>httpRequest</var>'s
-   <a for=request>header list</a>.
+   <li>
+    <p>If <var>httpRequest</var>'s <a for=request>header list</a> <a for="header list">does not
+    contain</a> `<code>User-Agent</code>`, then:
+
+    <ol>
+     <li><p>Let <var>userAgent</var> be the result of running the <a>WebDriver BiDi emulated
+     User-Agent</a> with <var>httpRequest</var>'s <a for=request>client</a>.

No newlines inside `<a>`.

> +     <li><p>If <var>userAgent</var> is null, set <var>userAgent</var> to <a>default
+     `<code>User-Agent</code>` value</a>.

then set*

> @@ -5889,11 +5889,20 @@ run these steps:
    the <a data-lt="structured field token">token</a> <code>prefetch</code>) in
    <var>httpRequest</var>'s <a for=request>header list</a>.
 
-   <li><p>If <var>httpRequest</var>'s <a for=request>header list</a>
-   <a for="header list">does not contain</a> `<code>User-Agent</code>`, then user agents should
-   <a for="header list">append</a> (`<code>User-Agent</code>`,
-   <a>default `<code>User-Agent</code>` value</a>) to <var>httpRequest</var>'s
-   <a for=request>header list</a>.
+   <li>
+    <p>If <var>httpRequest</var>'s <a for=request>header list</a> <a for="header list">does not
+    contain</a> `<code>User-Agent</code>`, then:
+
+    <ol>
+     <li><p>Let <var>userAgent</var> be the result of running the <a>WebDriver BiDi emulated
+     User-Agent</a> with <var>httpRequest</var>'s <a for=request>client</a>.

There's also a problem in that WebDriver hands us a string but we need a byte sequence.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1851#pullrequestreview-3229627315
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1851/review/3229627315@github.com>