Re: [w3c/push-api] Add app badge to Declarative Web Push (PR #402)

@annevk commented on this pull request.



>                  </p>
               </li>
               <li>
                 <p>
-                  Otherwise, set |notificationResult| to |registration|'s [=service worker
-                  registration/has shownotification() been successfully invoked|has
-                  `showNotification()` been successfully invoked=].
+                  Set |appBadgeResult| to true if {{NavigatorBadge/setAppBadge()}} has been
+                  invoked; otherwise false.

@marcoscaceres we need a hook for this similar to "has `showNotification()` been successfully invoked". People were not happy with this being defined in a hand-wavy way.

> @@ -1742,6 +1779,27 @@ <h2>
                       given |notification|.
                     </p>
                   </li>
+                  <li data-cite="appmanifest">
+                    <p>
+                      If |appBadgeSet| is false and the web application associated with the <a>push
+                      subscription</a> is an [=installed web application=]:

We should use |subscription| here, I think? Maybe

> If appBadgeSet is false and |subscription| has an associated installed web application:

> @@ -1742,6 +1779,27 @@ <h2>
                       given |notification|.
                     </p>
                   </li>
+                  <li data-cite="appmanifest">
+                    <p>
+                      If |appBadgeSet| is false and the web application associated with the <a>push
+                      subscription</a> is an [=installed web application=]:

Though it would be nice to also support this outside of installed web applications. But I suppose that's a separate change.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/402#pullrequestreview-3200147008
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/402/review/3200147008@github.com>