Re: [w3c/ServiceWorker] Fix: Align Cache API definitions with Storage spec (PR #1789)

@domenic commented on this pull request.

This looks substantively right to me.

> @@ -1952,9 +1952,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
 
     A <dfn id="dfn-name-to-cache-map">name to cache map</dfn> is an <a>ordered map</a> whose [=map/entry=] consists of a [=map/key=] (a string that represents the name of a [=request response list=]) and a [=map/value=] (a [=request response list=]).
 
-    Each [=/storage key=] has an associated [=name to cache map=].
-
-    The <dfn id="dfn-relevant-name-to-cache-map">relevant name to cache map</dfn> is the [=name to cache map=] associated with the [=/storage key=] [=obtain a storage key|obtained=] from [=this=]'s associated [=CacheStorage/global object=]'s [=environment settings object=].
+    The <dfn id="dfn-relevant-name-to-cache-map">relevant name to cache map</dfn> is a [=name to cache map=] obtained as the result of running [=obtain a local storage bottle map=] with [=this=]'s associated [=CacheStorage/global object=]'s [=environment settings object=] and "<code>caches</code>".

Nit: it should not be necessary to give your `<dfn>`s `id=""` values. (The main use is if you are changing the definition text and want to preserve any links to the old definition.)

Another nit (and it is a preexisting issue): `[=this=]` can only be used inside Web IDL algorithms. It looks like "relevant name to cache map" is only used inside such algorithms, but it is still confusing to see `[=this=]` used indirectly in such a way. The more traditional thing to do would be to say "the **relevant name to cache map** of a `CacheStorage` _obj_ is... _obj_'s associated..."

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1789#pullrequestreview-3195180260
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1789/review/3195180260@github.com>