- From: Copilot <notifications@github.com>
- Date: Tue, 02 Sep 2025 17:43:54 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/1187/review/3178574752@github.com>
@Copilot commented on this pull request. ## Pull Request Overview This PR exports the "identity" definition for installed web applications to make it referenceable from external specifications. The change updates the definition scope and all references throughout the document. - Updates the definition scope from "identity" to "installed web application/identity" with export class - Updates all references to use the new scoped definition format - Fixes a reference list item to use the correct "id" instead of "identity" --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/w3c/manifest/new/main/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub> > @@ -192,7 +192,7 @@ <h2> </li> <li>[=manifest/icons=] </li> - <li>[=manifest/identity=] + <li>[=manifest/id=] The reference should be `[=manifest/identity=]` to match the definition being discussed in this section, not `[=manifest/id=]`. The `id` is the member name, but the concept being referenced is the identity. ```suggestion <li>[=manifest/identity=] ``` -- Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/1187#pullrequestreview-3178574752 You are receiving this because you are subscribed to this thread. Message ID: <w3c/manifest/pull/1187/review/3178574752@github.com>
Received on Wednesday, 3 September 2025 00:43:58 UTC