Re: [w3c/screen-orientation] Add can-lock-orientation CSS media feature (PR #273)

@Copilot commented on this pull request.

## Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.





---

💡 <a href="/w3c/screen-orientation/new/gh-pages/.github?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.

> +          The <a>can-lock-orientation</a> media feature is a [=boolean
+          context=] media feature. It can be used to test whether the user
+          agent supports screen orientation locking functionality.

The description states this is a 'boolean context' media feature, but the feature defines discrete values (`none` and `auto`) rather than a simple boolean presence check. This appears to be a discrete value media feature (like `pointer: none | coarse | fine`), not a boolean context feature. Either clarify the terminology or update the feature design to use boolean syntax (e.g., `@media (can-lock-orientation)` matching when present).
```suggestion
          The <a>can-lock-orientation</a> media feature is a discrete value
          media feature. It can be used to test whether the user agent supports
          screen orientation locking functionality by querying its value (e.g.,
          <code>@media (can-lock-orientation: auto)</code>).
```

> +            @media (can-lock-orientation) {
+              .rotation-controls {
+                display: block;
+              }
+            }

The CSS example uses boolean syntax `@media (can-lock-orientation)` without specifying a value, but the feature is defined with discrete values (`none` | `auto`). For consistency with the feature definition, this should be `@media (can-lock-orientation: auto)` or the feature should be redesigned as a true boolean feature.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/273#pullrequestreview-3386953972
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/screen-orientation/pull/273/review/3386953972@github.com>