- From: Copilot <notifications@github.com>
- Date: Mon, 20 Oct 2025 21:17:43 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/screen-orientation/pull/267/review/3358705704@github.com>
@Copilot commented on this pull request.
## Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
---
<sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/w3c/screen-orientation/new/gh-pages/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>
> + <li>If the [=user agent=] requires |document| and its
+ associated [=Document/browsing context=] to meet [=pre-lock
+ conditions=] in order to [=lock the screen orientation=], and those
+ conditions are not met, return [=a promise rejected with=] a
+ {{"NotSupportedError"}} {{DOMException}} and abort these steps.
+ </li>
The reference to 'pre-lock conditions' is used before it is defined. Consider either defining the term before the algorithm or using forward reference syntax to indicate the definition comes later in the document.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/267#pullrequestreview-3358705704
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/screen-orientation/pull/267/review/3358705704@github.com>
Received on Tuesday, 21 October 2025 04:17:47 UTC