- From: Copilot <notifications@github.com>
- Date: Fri, 17 Oct 2025 00:32:04 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/screen-orientation/pull/273/review/3348668516@github.com>
@Copilot commented on this pull request. ## Pull Request Overview This PR adds a new CSS media feature `can-lock-orientation` that enables feature detection for screen orientation locking capabilities. The addition allows developers to conditionally style or display UI elements based on whether orientation locking is available in the current context. - Adds `can-lock-orientation` media feature with `none` and `auto` values - Includes privacy considerations to prevent fingerprinting through user preferences - Updates the abstract to reflect the new CSS integration --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/w3c/screen-orientation/new/gh-pages/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub> > + The `can-lock-orientation` media feature is a <a data-cite="mediaqueries-5#boolean-context">boolean context</a> + media feature. It can be used to test whether the user agent supports The feature is described as a boolean context media feature, but it explicitly defines two discrete values (`none` and `auto`). Boolean context media features typically don't have explicit values. Consider either removing the explicit values and using standard boolean syntax, or clarifying that this is a discrete media feature with two possible values rather than a boolean context feature. ```suggestion The `can-lock-orientation` media feature is a <a data-cite="mediaqueries-5#discrete">discrete</a> media feature with two possible values: <code>none</code> and <code>auto</code>. It can be used to test whether the user agent supports ``` > + <li>The user agent does not implement the Screen Orientation API</li> + <li>The document is not [=Document/fully active=]</li> + <li>The document has the [=sandboxed orientation lock browsing context flag=] set</li> + <li>The document's [=Document/visibility state=] is "hidden"</li> + <li>The current context doesn't meet the [=pre-lock conditions=]</li> [nitpick] Inconsistent list formatting: this list item lacks ending punctuation while other items in the list use semicolons or periods. Ensure consistent punctuation across all list items for better readability. ```suggestion <li>The user agent does not implement the Screen Orientation API.</li> <li>The document is not [=Document/fully active=].</li> <li>The document has the [=sandboxed orientation lock browsing context flag=] set.</li> <li>The document's [=Document/visibility state=] is "hidden".</li> <li>The current context doesn't meet the [=pre-lock conditions=].</li> ``` -- Reply to this email directly or view it on GitHub: https://github.com/w3c/screen-orientation/pull/273#pullrequestreview-3348668516 You are receiving this because you are subscribed to this thread. Message ID: <w3c/screen-orientation/pull/273/review/3348668516@github.com>
Received on Friday, 17 October 2025 07:32:08 UTC