- From: Copilot <notifications@github.com>
- Date: Thu, 16 Oct 2025 23:08:05 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/screen-orientation/pull/270/review/3348435266@github.com>
@Copilot commented on this pull request. ## Pull Request Overview Adds a continuous monitoring step to the “apply orientation lock” algorithm so that pre-lock conditions are re-checked and the orientation lock is fully unlocked when those conditions cease to hold. This aims to prevent stale orientation locks outside of the Fullscreen API hooks. - Add a monitoring step to run “fully unlock” when pre-lock conditions no longer hold - Integrate the step to run in parallel with the algorithm’s processing --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/w3c/screen-orientation/new/gh-pages/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub> > + <li>If any [=pre-lock conditions=] are no longer met while [=in + parallel=], run the [=fully unlock the screen orientation steps=] + with |document|. [nitpick] The phrasing 'while in parallel' is unclear/unidiomatic for W3C spec prose; typically steps are phrased as 'In parallel, ...'. Suggest rewording to: 'In parallel, if any [=pre-lock conditions=] are no longer met, run the [=fully unlock the screen orientation steps=] with |document|.' ```suggestion <li>In parallel, if any [=pre-lock conditions=] are no longer met, run the [=fully unlock the screen orientation steps=] with |document|. ``` -- Reply to this email directly or view it on GitHub: https://github.com/w3c/screen-orientation/pull/270#pullrequestreview-3348435266 You are receiving this because you are subscribed to this thread. Message ID: <w3c/screen-orientation/pull/270/review/3348435266@github.com>
Received on Friday, 17 October 2025 06:08:09 UTC