- From: Marcos Cáceres <notifications@github.com>
- Date: Thu, 16 Oct 2025 22:19:06 -0700
- To: w3c/screen-orientation <screen-orientation@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/screen-orientation/pull/269@github.com>
This commit modernizes how the Screen Orientation specification responds to fullscreen request rejections by using the WebIDL 'react' concept instead of the previous flag-based approach. Changes: - Replace flag-based 'pending fullscreen request flag unset due to rejection' pattern - Use WebIDL 'react' pattern with 'pending fullscreen request promise' - Update reference to use proper 'pending fullscreen request flag' terminology - Maintain all existing algorithm behavior while modernizing the specification architecture This enables cleaner, more maintainable specification text that follows modern WebIDL patterns for promise-based APIs. The change complements the fullscreen spec changes in whatwg/fullscreen that add both the exported flag and promise definitions needed for this integration. Closes #254 Closes #255 The following tasks have been completed: * [ ] Modified Web platform tests (link to pull request) Implementation commitment: * [ ] WebKit (https://bugs.webkit.org/enter_bug.cgi) * [ ] Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=) * [ ] Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=) <!-- This comment and the below content is programmatically generated. You may add a comma-separated list of anchors you'd like a direct link to below (e.g. #idl-serializers, #idl-sequence): Don't remove this comment or modify anything below this line. If you don't want a preview generated for this pull request, just replace the whole of this comment's content by "no preview" and remove what's below. --> *** <a href="https://pr-preview.s3.amazonaws.com/w3c/screen-orientation/pull/269.html" title="Last updated on Oct 17, 2025, 5:18 AM UTC (7c2c201)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/screen-orientation/269/245ed44...7c2c201.html" title="Last updated on Oct 17, 2025, 5:18 AM UTC (7c2c201)">Diff</a> You can view, comment on, or merge this pull request online at: https://github.com/w3c/screen-orientation/pull/269 -- Commit Summary -- * Refactor fullscreen rejection handling to use WebIDL react pattern -- File Changes -- M index.html (84) -- Patch Links -- https://github.com/w3c/screen-orientation/pull/269.patch https://github.com/w3c/screen-orientation/pull/269.diff -- Reply to this email directly or view it on GitHub: https://github.com/w3c/screen-orientation/pull/269 You are receiving this because you are subscribed to this thread. Message ID: <w3c/screen-orientation/pull/269@github.com>
Received on Friday, 17 October 2025 05:19:10 UTC