Re: [w3c/screen-orientation] Editorial: Fix pre-lock conditions algorithm structure (PR #267)

@Copilot commented on this pull request.

## Pull Request Overview

Clarifies the Screen Orientation locking algorithm by isolating and formalizing “pre-lock conditions” to improve readability and normative flow.
- Moves the “pre-lock conditions” definition out of the interleaved intro paragraph.
- Adds an explicit optional algorithm step that rejects when pre-lock conditions are required but unmet.
- Rewords and links the definition section to relevant interactions (app manifest and fullscreen).





---

<sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/w3c/screen-orientation/new/gh-pages/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>

> +          <li>Optionally, if the [=user agent=] requires |document| and its
+          associated [=Document/browsing context=] to meet [=pre-lock
+          conditions=] in order to [=lock the screen orientation=], and those
+          conditions are not met, return [=a promise rejected with=] a
+          {{"NotSupportedError"}} {{DOMException}} and abort these steps.
+          </li>

[nitpick] The leading “Optionally,” makes the requirement ambiguous: if a user agent has chosen to require pre-lock conditions, the rejection when they are not met should not itself be optional. Suggest removing “Optionally,” so the step reads “If the [=user agent=] requires … and those conditions are not met, return …”.

> @@ -429,6 +429,14 @@ <h2>
           <li>Return |document|'s {{Document/[[orientationPendingPromise]]}}.
           </li>
         </ol>
+        <p>
+          <dfn>Pre-lock conditions</dfn> are optional requirements that a
+          [=user agent=] MAY impose before allowing screen orientation locking.
+          Common pre-lock conditions include requiring the document to be in
+          fullscreen mode or be part of an installed web application. See

Improve grammatical parallelism by changing “or be part of” to “or being part of”.
```suggestion
          fullscreen mode or being part of an installed web application. See
```

> @@ -429,6 +429,14 @@ <h2>
           <li>Return |document|'s {{Document/[[orientationPendingPromise]]}}.
           </li>
         </ol>
+        <p>
+          <dfn>Pre-lock conditions</dfn> are optional requirements that a

[nitpick] For consistency with references like [=pre-lock conditions=] and typical Bikeshed practice, consider using lowercase in the <dfn>: <dfn>pre-lock conditions</dfn>. This keeps the term’s canonical form aligned with link text and prior usage.
```suggestion
          <dfn>pre-lock conditions</dfn> are optional requirements that a
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/267#pullrequestreview-3345942496
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/screen-orientation/pull/267/review/3345942496@github.com>