- From: stelar7 <notifications@github.com>
- Date: Wed, 15 Oct 2025 07:51:41 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/IndexedDB/pull/478@github.com>
Since [getAllKeys](https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getallkeys) takes an `any` parameter, we cant be sure that the object we get is of the type `IDBGetAllOptions`. As such, there is no default values applied to the object passed in. If the object passed then doesnt contain direction, we will try to call `retrieve_multiple_items_from_an_XXX` with an undefined value for `direction.` I assume this is not the intention, and as such this PR aims to set the default value of `"next"` in those cases. The same would apply to `query` and `count`, but those are explicitly handled to return an unbounded key, and infinite results in other places. The following tasks have been completed: * [x] Confirmed there are no ReSpec/BikeShed errors or warnings. * [ ] Modified Web platform tests (link to pull request) Implementation commitment: * [ ] WebKit (https://bugs.webkit.org/show_bug.cgi?id=) * [ ] Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=) * [ ] Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=) <!-- This comment and the below content is programmatically generated. You may add a comma-separated list of anchors you'd like a direct link to below (e.g. #idl-serializers, #idl-sequence): Don't remove this comment or modify anything below this line. If you don't want a preview generated for this pull request, just replace the whole of this comment's content by "no preview" and remove what's below. --> *** <a href="https://pr-preview.s3.amazonaws.com/stelar7/IndexedDB/pull/478.html" title="Last updated on Oct 15, 2025, 2:51 PM UTC (0a4563a)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/IndexedDB/478/f704918...stelar7:0a4563a.html" title="Last updated on Oct 15, 2025, 2:51 PM UTC (0a4563a)">Diff</a> You can view, comment on, or merge this pull request online at: https://github.com/w3c/IndexedDB/pull/478 -- Commit Summary -- * Adjust how the direction is defaulted in "Creating a request to retrieve multiple items" -- File Changes -- M index.bs (4) -- Patch Links -- https://github.com/w3c/IndexedDB/pull/478.patch https://github.com/w3c/IndexedDB/pull/478.diff -- Reply to this email directly or view it on GitHub: https://github.com/w3c/IndexedDB/pull/478 You are receiving this because you are subscribed to this thread. Message ID: <w3c/IndexedDB/pull/478@github.com>
Received on Wednesday, 15 October 2025 14:51:45 UTC