Re: [whatwg/fetch] Add WebDriver BiDi network request logging (PR #1540)

@OrKoN commented on this pull request.



> @@ -4826,6 +4840,11 @@ steps:
      <a for=request>URL</a>, <var>fetchParams</var>'s <a for="fetch params">request</a>'s
      <a for=request>initiator type</a>, <var>global</var>, <var>cacheState</var>,
      <var>bodyInfo</var>, and <var>responseStatus</var>.
+
+     <li><p>If <var>response</var> is a <a>network error</a>, run
+     the <a>WebDriver BiDi fetch error</a> steps with <var>request</var>. Otherwise
+     run the <a>WebDriver BiDi response completed</a> steps with

I failed to find a conclusive answer so far so posting a question here: do we expect this to be called if the client never reads the response body (e.g., `void fetch('...')`)? As far as I see, this is used as a flush algorithm for a stream pipe and it looks like it might not get called if the body is not read by the client until the browser decides to clean up the stream. cc @jgraham @sadym-chromium @juliandescottes

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1540#pullrequestreview-3328642648
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1540/review/3328642648@github.com>