- From: Noam Rosenthal <notifications@github.com>
- Date: Wed, 08 Oct 2025 05:32:31 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 8 October 2025 12:32:34 UTC
@noamr commented on this pull request. > @@ -6273,6 +6273,11 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps: <ol> <li><p>Let <var>request</var> be <var>fetchParams</var>'s <a for="fetch params">request</a>. + <li><p>Let <var>isEmulatedOffline</var> be the result of <a>WebDriver BiDi network is offline</a> + with <var>request</var>'s <a for=request>client</a>. + + <li><p>If <var>isEmulatedOffline</var> is true, then return a <a>network error</a>. I don't think you need the variable, you can condense it to return a `network error` if the check returned true. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1852#pullrequestreview-3314599362 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1852/review/3314599362@github.com>
Received on Wednesday, 8 October 2025 12:32:34 UTC