Re: [w3c/screen-orientation] Add can-lock-orientation CSS media feature (PR #273)

@Copilot commented on this pull request.

## Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.





---

💡 <a href="/w3c/screen-orientation/new/gh-pages/.github/instructions?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.

> @@ -47,11 +47,14 @@
         specification, exposes the current type and angle of the device's
         screen orientation, and dispatches events when it changes. This enables
         web applications to programmatically adapt the user experience for
-        multiple screen orientations, working alongside CSS. This API is
-        particularly useful for applications such as computer games, where
-        users physically rotate the device, but the screen orientation itself
-        should not change. The API restricts locking the screen orientation
-        only if certain [=pre-lock conditions=] are met.
+        multiple screen orientations, working alongside CSS. 
+        The API restricts locking the screen orientation
+        only if certain [=pre-lock conditions=] are met. 
+        This API particularly useful for applications such as

Missing word "is" before "particularly useful". Should be "This API is particularly useful for applications..."
```suggestion
        This API is particularly useful for applications such as
```

> +        <p>
+          The <a>can-lock-orientation</a> media feature can be used to test
+          whether the user agent supports screen orientation locking
+          functionality.
+        </p>

[nitpick] These lines appear redundant with the initial description at lines 917-921. The description "The can-lock-orientation media feature can be used to test whether the user agent supports screen orientation locking functionality" repeats the same information as "used to query whether the user agent supports locking the screen orientation in the current context." Consider removing this paragraph to avoid redundancy.
```suggestion

```

> +          functionality.
+        </p>
+        <dl>
+          <dt>
+            `none`
+          </dt>
+          <dd>
+            <p>
+              The user agent does not support screen orientation locking, or
+              locking is not possible in the current context. This includes
+              cases where:
+            </p>
+            <ul>
+              <li>The user agent does not implement the Screen Orientation API
+              </li>
+              <li>The document is not [=Document/fully active=]

The condition "The document is not [=Document/fully active=]" is less specific than the actual check performed by the API. According to the common safety checks (line 487-490), the API checks if the document is a "fully active descendant of a top-level traversable with user attention", not just "fully active". Consider updating this to match the actual API requirement to ensure consistency and accuracy.
```suggestion
              <li>The document is not a [=Document/fully active=] descendant of a top-level traversable with user attention
```

> @@ -47,11 +47,14 @@
         specification, exposes the current type and angle of the device's
         screen orientation, and dispatches events when it changes. This enables
         web applications to programmatically adapt the user experience for
-        multiple screen orientations, working alongside CSS. This API is
-        particularly useful for applications such as computer games, where
-        users physically rotate the device, but the screen orientation itself
-        should not change. The API restricts locking the screen orientation
-        only if certain [=pre-lock conditions=] are met.
+        multiple screen orientations, working alongside CSS. 
+        The API restricts locking the screen orientation
+        only if certain [=pre-lock conditions=] are met. 
+        This API particularly useful for applications such as
+        computer games, where users physically rotate the device, but the
+        screen orientation itself should not change. The specification also
+        defines CSS media features to enable feature detection of orientation

[nitpick] The text uses the plural "CSS media features" but only one media feature (`can-lock-orientation`) is being defined in this specification. Consider using the singular "CSS media feature" for accuracy, or if multiple features are planned, this is fine as is.
```suggestion
        defines a CSS media feature to enable feature detection of orientation
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/273#pullrequestreview-3507996506
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/screen-orientation/pull/273/review/3507996506@github.com>