Re: [whatwg/dom] Set registry on null registry element on adopt instead of on insert (PR #1423)

rniwa left a comment (whatwg/dom#1423)

> @rniwa One thing I'd like to clarify from your [PR](https://github.com/WebKit/WebKit/pull/54004): One of the test files added is phrased as "append does not upgrade". However, is it correct that we still want to run upgrade during append/insertion steps?

So regular append should upgrade elements that have a non-null custom element registry. An element with null registry should retain its null registry state and not get upgraded upon insertion.

> It is possible that a null registry element gets a registry when it's appended cross document (which involves adopt steps). In that case we'll want to run an upgrade on the element right? Want to make sure I got the correct understanding here.

Yes, in the cross-document append case, we'd first adopt the element to the destination document at which point the null registry will be replaced with the global registry of the destination document.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1423#issuecomment-3550305203
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1423/c3550305203@github.com>