Re: [whatwg/dom] Set registry on null registry element on adopt instead of on insert (PR #1423)

@ja-y-son commented on this pull request.



> @@ -6018,12 +6006,14 @@ these steps:
     <ol>
      <li><p>Set <var>inclusiveDescendant</var>'s <a for=Node>node document</a> to <var>document</var>.
 
-     <li><p>If <var>inclusiveDescendant</var> is a <a for=/>shadow root</a> and
-     <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a>
-     <a>is a global custom element registry</a>, then set <var>inclusiveDescendant</var>'s
-     <a for=ShadowRoot>custom element registry</a> to <var>document</var>'s
-     <a>effective global custom element registry</a>.
-
+     <li><p>If <var>inclusiveDescendant</var> is a <a for=/>shadow root</a>:
+      <ol>
+        <li>If <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a>
+        <a>is a global custom element registry</a> or null, then set <var>inclusiveDescendant</var>'s
+        <a for=ShadowRoot>custom element registry</a> to <var>document</var>'s
+        <a>effective global custom element registry</a>.

We do not assign custom element registry during insertion steps so that will account for "keep custom element registry null", but then we need to assign the global registry at adopt steps to ensure the backwards compatibility.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1423#discussion_r2539994570
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1423/review/3480133071@github.com>