Re: [whatwg/webidl] Editorial: add missing args for CreateBuiltinFunction (PR #1539)

@Ms2ger approved this pull request.

This seems reasonable. Are the length/name observable for any of the functions that didn't previously have them defined explicitly?

> +    1.  Let |F| be <a abstract-op>CreateBuiltinFunction</a>(|steps|, 0, |name|, « », |realm|).
     1.  Return |F|.

Probably these two steps could be merged now.

> +    1.  Let |F| be <a abstract-op>CreateBuiltinFunction</a>(|steps|, 1, |name|, « », |realm|).
     1. Return |F|.

Ditto (and this would fix the inconsistent indentation too).

> @@ -12827,9 +12815,7 @@ then there must exist a property with the following characteristics:
                 1.  Return a newly created [=default iterator object=] for |definition|, with
                     |jsValue| as its [=default iterator object/target=], "<code>key</code>" as its
                     [=default iterator object/kind=], and [=default iterator object/index=] set to 0.
-            1.  Let |F| be [$CreateBuiltinFunction$](|steps|, « », |realm|).
-            1.  Perform [$SetFunctionName$](|F|, "<code>keys</code>").
-            1.  Perform [$SetFunctionLength$](|F|, 0).
+            1.  Let |F| be [$CreateBuiltinFunction$](|steps|, 0, <code>keys</code>, « », |realm|).

```suggestion
            1.  Let |F| be [$CreateBuiltinFunction$](|steps|, 0, "<code>keys</code>", « », |realm|).
```

> @@ -12841,9 +12827,7 @@ then there must exist a property with the following characteristics:
                 1.  Return a newly created [=default iterator object=] for |definition|, with
                     |jsValue| as its [=default iterator object/target=], "<code>value</code>" as its
                     [=default iterator object/kind=], and [=default iterator object/index=] set to 0.
-            1.  Let |F| be [$CreateBuiltinFunction$](|steps|, « », |realm|).
-            1.  Perform [$SetFunctionName$](|F|, "<code>values</code>").
-            1.  Perform [$SetFunctionLength$](|F|, 0).
+            1.  Let |F| be [$CreateBuiltinFunction$](|steps|, 0, <code>values</code>, « », |realm|).

```suggestion
            1.  Let |F| be [$CreateBuiltinFunction$](|steps|, 0, "<code>values</code>", « », |realm|).
```

> @@ -12867,9 +12851,7 @@ then there must exist a property with the following characteristics:
                     1.  Set |pairs| to |idlObject|'s current list of
                         [=value pairs to iterate over=]. (It might have changed.)
                     1.  Set |i| to |i| + 1.
-            1.  Let |F| be [$CreateBuiltinFunction$](|steps|, « », |realm|).
-            1.  Perform [$SetFunctionName$](|F|, "<code>forEach</code>").
-            1.  Perform [$SetFunctionLength$](|F|, 1).
+            1.  Let |F| be [$CreateBuiltinFunction$](|steps|, 1, <code>forEach</code>, « », |realm|).

```suggestion
            1.  Let |F| be [$CreateBuiltinFunction$](|steps|, 1, "<code>forEach</code>", « », |realm|).
```

> @@ -13004,9 +12986,7 @@ and the string "<code> Iterator</code>".
             1.  Run the [=asynchronous iterator initialization steps=] for |definition| with
                 |idlObject|, |iterator|, and |idlArgs|, if any such steps exist.
             1.  Return |iterator|.
-        1.  Let |F| be [$CreateBuiltinFunction$](|steps|, « », |realm|).
-        1.  Perform [$SetFunctionName$](|F|, "<code>entries</code>").
-        1.  Perform [$SetFunctionLength$](|F|, 0).
+        1.  Let |F| be [$CreateBuiltinFunction$](|steps|, 0, <code>entries</code>, « », |realm|).

```suggestion
        1.  Let |F| be [$CreateBuiltinFunction$](|steps|, 0, "<code>entries</code>", « », |realm|).
```

> @@ -13052,9 +13030,7 @@ and the string "<code> Iterator</code>".
             1.  Run the [=asynchronous iterator initialization steps=] for |definition| with
                 |idlObject|, |iterator|, and |idlArgs|, if any such steps exist.
             1.  Return |iterator|.
-        1.  Let |F| be [$CreateBuiltinFunction$](|steps|, « », |realm|).
-        1.  Perform [$SetFunctionName$](|F|, "<code>values</code>").
-        1.  Perform [$SetFunctionLength$](|F|, 0).
+        1.  Let |F| be [$CreateBuiltinFunction$](|steps|, 0, <code>values</code>, « », |realm|).

```suggestion
        1.  Let |F| be [$CreateBuiltinFunction$](|steps|, 0, "<code>values</code>", « », |realm|).
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/webidl/pull/1539#pullrequestreview-3448536481
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/webidl/pull/1539/review/3448536481@github.com>