- From: Anne van Kesteren <notifications@github.com>
- Date: Mon, 10 Nov 2025 16:49:20 -0800
- To: whatwg/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 11 November 2025 00:49:23 UTC
@annevk approved this pull request.
This looks good to me. Might be good if someone else takes a look too though, maybe @Ms2ger or @saschanaz?
> @@ -13195,7 +13171,7 @@ The \[[Prototype]] [=/internal slot=] of an [=asynchronous iterator prototype ob
1. If |ongoingPromise| is not null, then:
1. Let |afterOngoingPromiseCapability| be [=!=] [$NewPromiseCapability$]({{%Promise%}}).
- 1. Let |onSettled| be [$CreateBuiltinFunction$](|nextSteps|, « »).
+ 1. Let |onSettled| be [$CreateBuiltinFunction$](|nextSteps|, 0, "", « »).
Why is this one 0? It seems elsewhere you default to 1.
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/webidl/pull/1539#pullrequestreview-3445751966
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/webidl/pull/1539/review/3445751966@github.com>
Received on Tuesday, 11 November 2025 00:49:23 UTC