- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Tue, 27 May 2025 18:56:31 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 28 May 2025 01:56:35 UTC
@yoshisatoyanagisawa commented on this pull request.
> @@ -3278,6 +3300,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. If |navigationPreloadResponse|'s [=response/type=] is "`error`", reject |preloadResponse| with a `TypeError` and terminate these substeps.
1. Associate |preloadResponseObject| with |navigationPreloadResponse|.
+ 1. If |timingInfo|'s [=service worker timing info/worker final router source=]is set to {{RouterSourceEnum/"network"}}, Set |timingInfo|'s [=service worker timing info/worker final router source=] be set to {{RouterSourceEnum/"fetch-event"}}.
Thanks for the explanation. Yeah, fetch-event's final router source can be network if fallback.
https://github.com/WICG/service-worker-static-routing-api/blob/main/resource-timing-api.md#correspondence-of-the-matched-source-type-and-the-actual-source-type
I missed that.
However, as we talked offline, we might need to see the [Create Fetch Event and Dispatch](https://w3c.github.io/ServiceWorker/#create-fetch-event-and-dispatch) response instead.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1769#discussion_r2110716063
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/ServiceWorker/pull/1769/review/2873308631@github.com>
Received on Wednesday, 28 May 2025 01:56:35 UTC