- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Sun, 25 May 2025 22:11:46 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 26 May 2025 05:11:50 UTC
@yoshisatoyanagisawa commented on this pull request. > @@ -3278,6 +3300,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/ 1. If |navigationPreloadResponse|'s [=response/type=] is "`error`", reject |preloadResponse| with a `TypeError` and terminate these substeps. 1. Associate |preloadResponseObject| with |navigationPreloadResponse|. + 1. If |timingInfo|'s [=service worker timing info/worker final router source=]is set to {{RouterSourceEnum/"network"}}, Set |timingInfo|'s [=service worker timing info/worker final router source=] be set to {{RouterSourceEnum/"fetch-event"}}. Sorry for my bad explanation. I should have said L3285 instead. This is the end of if-else started from L3236, and we are sure that |source| is fetch-event because we assert. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1769#discussion_r2106522255 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1769/review/2867234597@github.com>
Received on Monday, 26 May 2025 05:11:50 UTC