- From: Keita Suzuki <notifications@github.com>
- Date: Sun, 25 May 2025 18:42:42 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 26 May 2025 01:42:49 UTC
@quasi-mod commented on this pull request. > @@ -3278,6 +3300,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/ 1. If |navigationPreloadResponse|'s [=response/type=] is "`error`", reject |preloadResponse| with a `TypeError` and terminate these substeps. 1. Associate |preloadResponseObject| with |navigationPreloadResponse|. + 1. If |timingInfo|'s [=service worker timing info/worker final router source=]is set to {{RouterSourceEnum/"network"}}, Set |timingInfo|'s [=service worker timing info/worker final router source=] be set to {{RouterSourceEnum/"fetch-event"}}. This line is to set the final router source when the matched rule is "fetch-event". IIUC, final router source in L3284 is for the results of race, so if we directly match to "fetch-event", we won't go through the step. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1769#discussion_r2106388328 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1769/review/2867048411@github.com>
Received on Monday, 26 May 2025 01:42:49 UTC