Re: [w3c/IndexedDB] Return transaction from upgrade a database (PR #458)

@evanstade commented on this pull request.



>  
     1. If |connection| was [=connection/closed=],
         return a newly [=exception/created=]
         "{{AbortError}}" {{DOMException}} and abort these steps.
 
-    1. If the [=/upgrade transaction=] was aborted, run the steps

I don't think you need to return a value from `upgrade a database` as the request's transaction will be set to the transaction, although only if it succeeded. If it was aborted, the request's transaction will be null and done flag will be false. So this can change to something like "If |request|'s [=request/transaction=] is null, run the steps to..."

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/458#pullrequestreview-2861826636
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/IndexedDB/pull/458/review/2861826636@github.com>