- From: Peter Reitinger <notifications@github.com>
- Date: Thu, 22 May 2025 00:01:20 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 22 May 2025 07:01:24 UTC
preitinger left a comment (w3c/ServiceWorker#1771) OK, I am not used to the process here, but I think I have understood the following facts: - The typescript definition (at least in VS Code which I am using) wrongly tells that Promise<void> is returned by `update()`. - Almost all browsers return currently the same object on which `update()` is called. - The algorithms that are triggered by `update()` are consistently defined to return `Promise<ServiceWorkerRegistration>`. - The effort for changing the return value to `Promise<void>` would be huge in several areas. - Millions of JavaScript projects (not Typescript) might break if the return value would be changed. - Users who are confused at first glance, as me, can just ignore the return value. Have I understood it halfways? ;-) Thank you for your explanations! Have I to do anything like withdraw my pull request? -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1771#issuecomment-2900135502 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1771/c2900135502@github.com>
Received on Thursday, 22 May 2025 07:01:24 UTC