Re: [whatwg/fetch] Return a `content-encoding` header for resource timing and more (PR #1796)

@guohuideng2024 commented on this pull request.



> @@ -6319,6 +6321,23 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps:
          <li><p>Let <var>codings</var> be the result of <a>extracting header list values</a> given
          `<code>Content-Encoding</code>` and <var>response</var>'s <a for=response>header list</a>.
 
+         <li><p>Let <var>filteredCoding</var> be "<code>_</code>".

1) 
As far as I know the convention is that "missing" ==> "empty string", in the performance API. (not http header)

An example would be "content type". In the fetch standard, there is this sentence:
"If mimeType is not failure, then set bodyInfo’s content type to the result of minimizing a supported MIME type given mimeType."

And for the mime type extraction, around the phrase "To extract a MIME type from a header list headers... ", the mimeType is a failure if the value is null.

Therefore, a "failure" or "null" mimeType value results in the "content type" value in bodyInfo being an empty string.
Then, in the resource timing specification, it's this "content type value in bodyinfo" to be exposed in resource timing.

This PR makes a similar change and the "content encoding" is following the same path: it is filtered here before gets into the same "bodyInfo"(and later be exposed in resource timing). And just like "content type", a "null" and "failure" value results an empty string.

2)
Yes I think `@unknown` is a good idea :)  I don't expect it there would be objects. However, how about let me update in https://github.com/w3c/resource-timing/issues/381 and wait for two days before we finalize this PR?( I will replace `_` with `@unknown`) 

Do you have any (other) concerns at this point? Would you let me know if you have any?

Cheers,
Guohui 






-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1796#discussion_r2089673902
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1796/review/2841399353@github.com>