Re: [w3c/ServiceWorker] Add new fields and getter steps for static routing resource timing (PR #1769)

@yoshisatoyanagisawa commented on this pull request.



>                    1. Let |raceFetchController| be null.
                   1. Let |raceResponse| be a [=race response=] whose [=race response/value=] is "<code>pending</code>".
                   1. Run the following substeps [=in parallel=], but [=abort when=] |fetchController|'s [=fetch controller/state=] is "<code>terminated</code>" or "<code>aborted</code>":
                       1. Set |raceFetchController| to the result of calling [=fetch=] given |request|, with [=fetch/processResponse=] set to the following steps given a [=/response=] |raceNetworkRequestResponse|:
                           1. If |raceNetworkRequestResponse|'s [=response/status=] is [=ok status=], then:
                               1. Set |raceResponse|'s [=race response/value=] to |raceNetworkRequestResponse|.
-                              1. [=queue/Enqueue=] |raceNetworkRequestResponse| to |queue|.
+                              1. [=queue/Enqueue=] |raceNetworkRequestResponse| as [=race result/race response=] and {{RouterSourceEnum/"network"}} as [=race result/used route=] to |queue|.

I think it is natural to separate this to several steps. e.g.
1. Let |race result| be a new [=race result=] whose [=race result/race response=] is set to |raceNetworkRequestResponse|, and [=race result/used route=] is set to {{RouterSourceEnum/"network"}}.
2. [=queue/Enqueue=] |race result| to |queue|.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1769#pullrequestreview-2838539116
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1769/review/2838539116@github.com>