- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 13 May 2025 01:34:39 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1823/review/2835794455@github.com>
@domenic commented on this pull request. > @@ -5517,10 +5560,13 @@ run these steps: <a for="fetch params">canceled</a>: <ol> - <li><p>If <var>request</var>'s <a for=request>window</a> is "<code>no-window</code>" and - <var>request</var>'s <a for=request>redirect mode</a> is "<code>error</code>", then set - <var>httpFetchParams</var> to <var>fetchParams</var> and <var>httpRequest</var> to - <var>request</var>. + <li> + <p>If <var>request</var>'s <a for=request>traversable for user prompts</a> is "<code>no-traversable</code>" and + <var>request</var>'s <a for=request>redirect mode</a> is "<code>error</code>", then set + <var>httpFetchParams</var> to <var>fetchParams</var> and <var>httpRequest</var> to + <var>request</var>. + + <p class=note>If user prompts are possible, then we need to clone <var>request</var> because ??? Right, OK, I think I forgot some details. But to recap: - Clients optimistically send the body to the server before getting the response headers back. - Certain response headers mean you need to restart the entire request, with a new set of request headers. Let me see if I can tweak the wording here to make it a bit more obvious, without necessarily restating too much... -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1823#discussion_r2086251936 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1823/review/2835794455@github.com>
Received on Tuesday, 13 May 2025 08:34:43 UTC