- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Thu, 08 May 2025 04:49:45 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 8 May 2025 11:49:49 UTC
@yoshisatoyanagisawa commented on this pull request. > 1. If |source| is {{RouterSourceEnum/"network"}}: 1. If |shouldSoftUpdate| is true, then [=in parallel=] run the [=Soft Update=] algorithm with |registration|. 1. Return null. 1. Else if |source| is {{RouterSourceEnum/"cache"}}, or |source|["{{RouterSourceDict/cacheName}}"] [=map/exists=], then: + 1. Set |timingInfo|’s [=service worker timing info/worker cache lookup start=] to the [=coarsened shared current time=] given |useHighResPerformanceTimers|. I guess this line goes just before L3236 because cache lookup starts from L3236. We may not want to include [=Soft Update=] time as cache lookup start time. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1769#pullrequestreview-2824870425 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1769/review/2824870425@github.com>
Received on Thursday, 8 May 2025 11:49:49 UTC