Re: [w3c/ServiceWorker] Update handle fetch algorithm step to consider null of source (PR #1768)

@yoshisatoyanagisawa commented on this pull request.



> -                      1. If |raceNetworkRequestResponse|'s [=response/status=] is [=ok status=], then:
-                          1. Set |raceResponse|'s [=race response/value=] to |raceNetworkRequestResponse|.
-                          1. [=queue/Enqueue=] |raceNetworkRequestResponse| to |queue|.
-                      1. Otherwise, set |raceResponse|'s [=race response/value=] to a [=network error=].
-              1. [=If aborted=] and |raceFetchController| is not null, then:
-                  1. [=fetch controller/Abort=] |raceFetchController|.
-                  1. Set |raceResponse| to a [=race response=] whose [=race response/value=] is null.
-              1. Resolve |preloadResponse| with undefined.
-              1. Run the following substeps [=in parallel=]:
-                  1. Let |fetchHandlerResponse| be the result of [=Create Fetch Event and Dispatch=] with |request|, |registration|, |useHighResPerformanceTimers|, |timingInfo|, |workerRealm|, |reservedClient|, |preloadResponse|, and |raceResponse|.
-                  1. If |fetchHandlerResponse| is not null and not a [=network error=], and |raceFetchController| is not null, [=fetch controller/abort=] |raceFetchController|.
-                  1. [=queue/Enqueue=] |fetchHandlerResponse| to |queue|.
-              1. Wait until |queue| is not empty.
-              1. Return the result of [=dequeue=] |queue|.
-          1. Assert: |source| is "{{RouterSourceEnum/fetch-event}}"
+          1. if |source| is non-null, then:

Nit but please starts with a capital letter.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1768#pullrequestreview-2820311140
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1768/review/2820311140@github.com>