Re: [whatwg/fetch] Return a `content-encoding` header for resource timing and more (PR #1796)

@annevk commented on this pull request.



> @@ -6319,6 +6321,23 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps:
          <li><p>Let <var>codings</var> be the result of <a>extracting header list values</a> given
          `<code>Content-Encoding</code>` and <var>response</var>'s <a for=response>header list</a>.
 
+         <li><p>Let <var>filteredCoding</var> be "<code>_</code>".
+
+         <li><p>If <var>codings</var> is null, then set <var>filteredCoding</var> to the empty string.
+
+         <li><p>Otherwise, if <var>codings</var>'s <a for=list>size</a> is greater than 1, then set
+         <var>filteredCoding</var> to "<code>multiple</code>".
+
+         <li><p>Otherwise, if <var>codings</var>[0] is the empty string, or it is supported by the user agent,
+         and is a <a>byte-case-insensitive</a> match for an entry listed in the
+         <a href="https://www.iana.org/assignments/http-parameters/http-parameters.xhtml#content-coding">

There's no need for the `<a>` here as we already have the [[ ]] reference. Though the [[ ]] reference should come at the end of the paragraph after the final dot.

> @@ -6319,6 +6321,23 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps:
          <li><p>Let <var>codings</var> be the result of <a>extracting header list values</a> given
          `<code>Content-Encoding</code>` and <var>response</var>'s <a for=response>header list</a>.
 
+         <li><p>Let <var>filteredCoding</var> be "<code>_</code>".
+
+         <li><p>If <var>codings</var> is null, then set <var>filteredCoding</var> to the empty string.
+
+         <li><p>Otherwise, if <var>codings</var>'s <a for=list>size</a> is greater than 1, then set

This doesn't work when _codings_ is failure.

> @@ -6319,6 +6321,23 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps:
          <li><p>Let <var>codings</var> be the result of <a>extracting header list values</a> given
          `<code>Content-Encoding</code>` and <var>response</var>'s <a for=response>header list</a>.
 
+         <li><p>Let <var>filteredCoding</var> be "<code>_</code>".

Are you updating the tests to account for this change? Can we make this `_unknown` you think? And then maybe instead of the empty string below we could make that `_missing`?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1796#pullrequestreview-2818560362
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1796/review/2818560362@github.com>