Re: [w3c/IndexedDB] Add handle to cursor to avoid exposing internal state to script (PR #455)

@inexorabletash requested changes on this pull request.

Overall looks good, with some suggestions.

> +When [=cursor/source handle=] is an [=index handle=], set [=cursor/source=] to [=index-handle/index|the index handle's associated index=].
+Otherwise, set [=cursor/source=] to [=object-store-handle/object store|the object store handle's associated object store=].

These lines read like imperative algorithm steps, but they don't have a trigger. How about this:

```suggestion
If the cursor's [=cursor/source handle=] is an [=index handle=], then the cursor's [=cursor/source=] is [=index-handle/index|the index handle's associated index=].
Otherwise, cursor's [=cursor/source=] is [=object-store-handle/object store|the object store handle's associated object store=].
```

> @@ -6721,6 +6719,7 @@ For the revision history of the second edition, see [that document's Revision Hi
 * Clarify that only [=transaction/inactive=] [=/transactions=] should attempt to auto-commit. (<#436>)
 * Correct [=/upgrade a database=] steps to handle aborted transactions. (<#436>)
 * Update [=/iterate a cursor=] value serialization to use [=/value=] for [=/object stores=] instead of [=index/referenced values=]. (<#452>)
+* Add [=cursor/source handle=] to [=/cursor=] to avoid exposing internal indexes and object stores to script.

```suggestion
* Add [=cursor/source handle=] to [=/cursor=] to avoid exposing internal indexes and object stores to script. (<#445>)
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/455#pullrequestreview-2816148928
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/IndexedDB/pull/455/review/2816148928@github.com>