- From: bvandersloot-mozilla <notifications@github.com>
- Date: Mon, 10 Mar 2025 11:12:24 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 10 March 2025 18:12:28 UTC
@bvandersloot-mozilla commented on this pull request. > @@ -5710,21 +5843,9 @@ run these steps: <p>If <var>includeCredentials</var> is true, then: <ol> - <li> - <p>If the user agent is not configured to block cookies for <var>httpRequest</var> (see - <a href=https://httpwg.org/specs/rfc6265.html#privacy-considerations>section 7</a> of - [[!COOKIES]]), then: - - <ol> - <li><p>Let <var>cookies</var> be the result of running the "cookie-string" algorithm (see - <a href=https://httpwg.org/specs/rfc6265.html#cookie>section 5.4</a> of - [[!COOKIES]]) with the user agent's cookie store and <var>httpRequest</var>'s - <a for=request>current URL</a>. + <p class=note>This permits some implementations to choose to not support cookies for some or all <var>httpRequest</var>s. > "This" here refers to the word "should" in the line below? Yes. Yeah, we can move the user-configuration logic into `append a request Cookie header`. Since you left this comment I split out the partitioning bits, so that may just resolve it. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1807#discussion_r1987794047 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1807/review/2671828729@github.com>
Received on Monday, 10 March 2025 18:12:28 UTC