Re: [w3c/ServiceWorker] Editorial: Queue a task to resolve/reject promise or when fire an event. (PR #1755)

@yoshisatoyanagisawa commented on this pull request.



> @@ -1384,8 +1388,8 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
             1. For each [=/service worker client=] |client| where the result of running [=obtain a storage key=] given |client| [=storage key/equals=] the associated [=ServiceWorkerGlobalScope/service worker=]'s [=containing service worker registration=]'s [=service worker registration/storage key=]:
                 1. If |client|'s [=environment/id=] is not |id|, [=continue=].
                 1. Wait for either |client|'s [=environment/execution ready flag=] to be set or for |client|'s [=discarded flag=] to be set.
-                1. If |client|'s [=environment/execution ready flag=] is set, then invoke [=Resolve Get Client Promise=] with |client| and |promise|, and abort these steps.
-            1. Resolve |promise| with undefined.
+                1. If |client|'s [=environment/execution ready flag=] is set, [=queue a task=] on |promise|'s [=relevant settings object=]'s [=responsible event loop=], using the [=DOM manipulation task source=], to invoke [=Resolve Get Client Promise=] with |client| and |promise|, and abort these steps.
+            1. [=Queue a task=] to resolve |promise| with undefined.

Sorry, I overlooked this.
I am reading this as multi thread programming, and data structure can be changed except it is executed within the queue that serialize the data structure manipulation.
When I read

> For each [service worker client](https://w3c.github.io/ServiceWorker/#dfn-service-worker-client) client where the result of running [obtain a storage key](https://storage.spec.whatwg.org/#obtain-a-storage-key) given client [equals](https://storage.spec.whatwg.org/#storage-key-equal) the associated [service worker](https://w3c.github.io/ServiceWorker/#serviceworkerglobalscope-service-worker)’s [containing service worker registration](https://w3c.github.io/ServiceWorker/#dfn-containing-service-worker-registration)’s [storage key](https://w3c.github.io/ServiceWorker/#service-worker-registration-storage-key):

I just wondered what happens if one of the service worker clients has been removed or gets execution ready flag during the sub step execution, and suggest to run Clients API algorithm within the dedicated parallel queue to prevent unexpected modifications to clients.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1755#discussion_r1981255275
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1755/review/2660873206@github.com>