Re: [whatwg/storage] Add top-level site and cross site ancestry to storage key (PR #182)

@annevk commented on this pull request.



> @@ -207,10 +208,10 @@ anticipated that some APIs will be applicable to both <a>storage types</a> going
 <h3 id=storage-keys>Storage keys</h3>
 
 <p>A <dfn export>storage key</dfn> is a <a>tuple</a> consisting of an
-<dfn for="storage key">origin</dfn> (an <a for=/>origin</a>). [[!HTML]]
-
-<p class=XXX>This is expected to change; see
-<a href="https://privacycg.github.io/storage-partitioning/">Client-Side Storage Partitioning</a>.
+<dfn for="storage key">origin</dfn> (an <a for=/>origin</a>), a 
+<dfn for="storage key">top-level site</dfn> (a <a for=/>site</a>), and a
+<dfn for="storage key">cross site ancestry</dfn>
+(a <a for=environment>cross site ancestry</a>). [[!HTML]]

This is a member, not a type. While some specifications confuse the two (and I've certainly made that mistake in the past), we shouldn't do that for anything new.

> + <li><p>Let <var>topLevelSite</var> be the result of of running <a>obtain a site</a>
+ given <var>topLevelOrigin</var>.

```suggestion
 <li><p>Let <var>topLevelSite</var> be the result of <a>obtaining a site</a> given
 <var>topLevelOrigin</var>.
```

> + <li><p>Return a tuple consisting of (<var>origin</var>, <var>topLevelSite</var>,
+ <var>crossSiteAncestry</var>).

```suggestion
 <li><p>Return (<var>origin</var>, <var>topLevelSite</var>, <var>crossSiteAncestry</var>).
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/storage/pull/182#pullrequestreview-2966745276
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/storage/pull/182/review/2966745276@github.com>