Re: [w3c/IndexedDB] Add getAllRecords() method and update getAll()/getAllKeys() to support direction option (PR #461)

@evanstade commented on this pull request.

only had a couple minutes to begin on review, but here is a modicum of feedback for now :)

> @@ -1371,6 +1371,38 @@ To <dfn>convert a value to a key range</dfn> with
 
 </div>
 
+
+A <dfn>potentially valid key range</dfn> is a value that is a [=key/type|type of key=] or a [=key range=].

Not sure if I follow this. Isn't it a value that is a *key* not a *type of key*?



> @@ -1371,6 +1371,38 @@ To <dfn>convert a value to a key range</dfn> with
 
 </div>
 
+
+A <dfn>potentially valid key range</dfn> is a value that is a [=key/type|type of key=] or a [=key range=].
+However, [=convert a value to a key range|converting=] a [=potentially valid key range=] to a [=key range=] could throw an exception.

I don't know if it has value or is idiomatic to have a self-referential link. i.e. the definition of "potentially valid key range" is linking back to the definition of "potentially valid key range"

wdyt?

> @@ -1371,6 +1371,38 @@ To <dfn>convert a value to a key range</dfn> with
 
 </div>
 
+
+A <dfn>potentially valid key range</dfn> is a value that is a [=key/type|type of key=] or a [=key range=].
+However, [=convert a value to a key range|converting=] a [=potentially valid key range=] to a [=key range=] could throw an exception.
+
+NOTE:
+  For example, a value that is a [=BufferSource/detached|detached BufferSource=] is a [=potentially valid key range=] that will throw an exception when used with [=convert a value to a key range=].
+
+<div algorithm>
+
+  To determine when a value <dfn>is a potentially valid key range</dfn> with |value|, run these steps:

is this different from running *convert a value to a key range* and returning true iff no exception was thrown?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/461#pullrequestreview-2963460296
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/IndexedDB/pull/461/review/2963460296@github.com>