Re: [w3c/manifest] Add `navigator.install()` (PR #1175)

@marcoscaceres commented on this pull request.



> +                  <li>[=Resolve=] [=this=].{{Navigator/[[installPromise]]}}
+                  with `undefined`.
+                  </li>
+                  <li>Set [=this=].{{Navigator/[[installPromise]]}} to `null`.
+                  </li>

I think we want this the other way around... otherwise, resolving the promise would immediately call the resolver function, which might put things in a weird state.  

```suggestion
                  <li>Set [=this=].{{Navigator/[[installPromise]]}} to `null`.
                  </li>
                   <li>[=Resolve=] [=this=].{{Navigator/[[installPromise]]}}
                  with `undefined`.
                  </li>
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1175#pullrequestreview-2948874496
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/pull/1175/review/2948874496@github.com>