- From: Steven Becker <notifications@github.com>
- Date: Fri, 13 Jun 2025 14:08:18 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 13 June 2025 21:08:25 UTC
@SteveBeckerMSFT requested changes on this pull request. Thanks for the fix! I left one question and potential update for us to discuss. > @@ -5144,8 +5148,7 @@ To <dfn>abort a transaction</dfn> with the |transaction| to abort, and |error|, 1. Set |transaction|'s [=transaction/state=] to [=transaction/finished=]. -1. If |error| is not null, set |transaction|'s - [=transaction/error=] to |error|. +1. Set |transaction|'s [=transaction/error=] to |error|. Do we need to include the condition that @inexorabletash [suggested in his proposed minimal fix](https://github.com/w3c/IndexedDB/issues/433#issuecomment-2512330086)? "If |error| us not set, set |transaction|'s [=transaction/error=] to |error|." I think this might be needed if we call "abort a transaction" on a transaction that is already aborted. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/IndexedDB/pull/460#pullrequestreview-2926423822 You are receiving this because you are subscribed to this thread. Message ID: <w3c/IndexedDB/pull/460/review/2926423822@github.com>
Received on Friday, 13 June 2025 21:08:25 UTC