- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 12 Jun 2025 18:03:25 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 13 June 2025 01:03:29 UTC
@domenic commented on this pull request. > @@ -3265,6 +3265,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/ 1. Let |raceResponse| be a [=race response=] whose [=race response/value=] is "<code>pending</code>". 1. Run the following substeps [=in parallel=], but [=abort when=] |fetchController|'s [=fetch controller/state=] is "<code>terminated</code>" or "<code>aborted</code>": I think since there is only one substep, it's better to restructure this to remove "abort when" / "if aborted" entirely: 1. Run the following steps in parallel: 1. If fetchController's state is "terminated" or "aborted", then: 1. Abort raceFetchController. 1. Set raceResponse to a race response whose value is null. 1. Set raceFetchController to the result of fetching given request, with processResponse set to the following steps given a response raceNetworkRequestResponse: 1. If fetchController's state is "terminated" or "aborted", then ... 1. ... This is equivalent to what is currently written, but clearer. The same comment applies below. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1779#pullrequestreview-2923107592 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1779/review/2923107592@github.com>
Received on Friday, 13 June 2025 01:03:29 UTC