Re: [w3c/IndexedDB] Return transaction from upgrade a database (PR #458)

@evanstade commented on this pull request.



>  
     1. If |connection| was [=connection/closed=],
         return a newly [=exception/created=]
         "{{AbortError}}" {{DOMException}} and abort these steps.
 
-    1. If the [=/upgrade transaction=] was aborted, run the steps

Good catch @stelar7.

I like Steve's idea.

> Is there some reason we dont want to have the return?

In general it seems preferable to work with the state that is already available, rather than making more state available to more of the system (especially when it is redundant). Returning the transaction changes its lifetime. There are fewer hypothetical side effects to reading state that already exists in the request.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/458#discussion_r2143666483
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/IndexedDB/pull/458/review/2922668698@github.com>

Received on Thursday, 12 June 2025 21:12:24 UTC