- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Thu, 12 Jun 2025 00:19:29 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 12 June 2025 07:19:35 UTC
@yoshisatoyanagisawa commented on this pull request. > @@ -3263,16 +3263,21 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/ 1. Let |queue| be an empty [=queue=] of [=race result=]. 1. Let |raceFetchController| be null. 1. Let |raceResponse| be a [=race response=] whose [=race response/value=] is "<code>pending</code>". + 1. Let |networkFetchCompleted| be false. + 1. Let |networkFetchResult| be null. Stepping back and see if I actually need to expand. My conclusion is we do not need to expand because: 1. [=network error=] is also response. 2. it might be totally fine to pass the non-ok status response instead of [=network error=]. 3. null should usually mean the error status, and it should be fine to be left null. Then, let me go without adding a new variable or field. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1777#discussion_r2141906407 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1777/review/2919834811@github.com>
Received on Thursday, 12 June 2025 07:19:35 UTC