Re: [w3c/IndexedDB] Add getAllRecords() method and update getAll()/getAllKeys() to support direction option (PR #461)

@evanstade approved this pull request.



> @@ -5488,6 +5548,7 @@ To <dfn>fire an error event</dfn> at a |request|, run these steps:
 
 </div>
 
+

nit: intentional?

>  
 </div>
 
+<aside class=advisement>
+  &#x1F6A7;
+  The {{IDBObjectStore/getAllRecords()}} method is new in this edition.

The other sites that use this wording mention which browsers/versions implement it. I guess the plan is to come back and add that after it actually passes Chromium's I2S?

Also might be good to add something like this for the changed getAll/getAllKeys param.

And finally, maybe "new in this edition" should link to the revision history section?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/461#pullrequestreview-3072953126
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/IndexedDB/pull/461/review/3072953126@github.com>