Re: [w3c/ServiceWorker] Add new environment settings object field "cross site ancestry" for SameSite cookies work (PR #1775)

@yoshisatoyanagisawa commented on this pull request.



> @@ -3065,6 +3065,11 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
               :: Return |serviceWorker|'s [=service worker/script url=].
               : The [=environment settings object/origin=]
               :: Return its registering [=/service worker client=]'s [=environment settings object/origin=].
+              : The [=environment settings object/cross site ancestry=]
+              :: Return its registering [=/service worker client=]'s [=environment settings object/cross site ancestry=].
+                <div class="note">
+                  Note: If service workers are not partitioned by the [=environment settings object/cross site ancestry=], clients must include logic to use the initial  [=/http fetch=]'s [=/request=]'s [=request/client=]'s [=environment settings object/cross site ancestry=] when determining the "<code>SameSite</code>" mode.

I've reopened this pull request, and I apologize if my earlier comments led to the misunderstanding and its closure.

To clarify, my intention was only to discuss the necessity of the note I had previously requested. I agree with @annevk's final assessment that we should still forward the field, and the conclusion of our discussion was that only the note should be removed, not the entire change in this PR.

The original purpose of this PR—adding the field for cross-site ancestry—is still necessary, though it may require renaming as @annevk pointed out separately.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1775#discussion_r2238494859
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1775/review/3065407435@github.com>