- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 24 Jul 2025 03:38:35 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1807/review/3051073661@github.com>
@annevk approved this pull request. This looks good, modulo some minor nits. We'll leave cookie clearing from the UI as one of the many follow-ups and scope this PR to just make the existing cookie integration much better defined. > <ol> <li><p><a for=/>Assert</a>: <var>request</var>'s <a for=request>origin</a> is not "<code>client</code>". <li><p>Let <var>lastURL</var> be null. + <li><p>Let <var>computedTaint</var> be "<code>same-origin</code>". ```suggestion <li><p>Let <var>taint</var> be "<code>same-origin</code>". ``` Can we rename this throughout? There's no good reason I think to make this variable long. > @@ -4227,6 +4259,127 @@ prefetch, or to treat it differently when counting page visits. +<h2 id=cookies>Cookies</h2> Looking at this again I think this should become a subsection of "HTTP extensions". Perhaps the first given the importance of cookies. > @@ -54,10 +54,29 @@ urlPrefix:https://tc39.es/ecma262/#;type:dfn;spec:ecma-262 url:realm;text:realm url:sec-list-and-record-specification-type;text:Record url:current-realm;text:current realm + +urlPrefix:https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-layered-cookies#;type:dfn;spec:cookies + url:name-cookie-store-and-limits;text:cookie store + url:name-parse-and-store-a-cookie;text:parse and store a cookie + url:name-parse-a-cookie;text:parse a cookie + url:name-store-a-cookie;text:store a cookie + url:name-retrieve-cookies;text:retrieve cookies + url:name-serialize-cookies;text:serialize cookies + url:name-garbage-collect-cookies;text:garbage collect cookies + +<!-- TODO: pending HTML changes- ancestor enum (https://github.com/whatwg/html/pull/10559), has storage access bit, initiator origin plumbing --> +urlPrefix:https://html.spec.whatwg.org#;type:dfn;spec:html + url:TODO;text:has cross-site ancestor;for:environment + url:TODO;text:has storage access;for:environment Let's remove "has storage access" for now. "has cross-site ancestor" might also need to renamed. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1807#pullrequestreview-3051073661 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1807/review/3051073661@github.com>
Received on Thursday, 24 July 2025 10:38:39 UTC