- From: Anne van Kesteren <notifications@github.com>
- Date: Fri, 18 Jul 2025 00:23:23 -0700
- To: whatwg/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/webidl/pull/1465/review/3032320542@github.com>
@annevk approved this pull request. I think setting `code` to 0 is an unnecessary breaking change. We might as well continue to initialize it properly and not frustrate a handful of people that might rely on it in some way. Modulo that and nits this looks good to me. > - 1. Run the {{DOMException}} [=deserialization steps=] given |serialized| and |value|. - 1. Set |value|'s [=ProtocolXError/error code=] to |serialized|.\[[ErrorCode]]. - </div> + 1. Set [=this=]'s [=DOMException/message=] to |message|. + + 1. If |options|["{{QuotaExceededErrorOptions/quota}}"] is present, then: ```suggestion 1. If |options|["{{QuotaExceededErrorOptions/quota}}"] is present: ``` > - 1. Run the {{DOMException}} [=deserialization steps=] given |serialized| and |value|. - 1. Set |value|'s [=ProtocolXError/error code=] to |serialized|.\[[ErrorCode]]. - </div> + 1. Set [=this=]'s [=DOMException/message=] to |message|. + + 1. If |options|["{{QuotaExceededErrorOptions/quota}}"] is present, then: + + 1. If |options|["{{QuotaExceededErrorOptions/quota}}"] is less than 0, then throw a + {{RangeError}}. + + 1. Set [=this=]'s [=QuotaExceededError/quota=] to + |options|["{{QuotaExceededErrorOptions/quota}}"]. + + 1. If |options|["{{QuotaExceededErrorOptions/requested}}"] is present, then: ```suggestion 1. If |options|["{{QuotaExceededErrorOptions/requested}}"] is present: ``` -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/webidl/pull/1465#pullrequestreview-3032320542 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/webidl/pull/1465/review/3032320542@github.com>
Received on Friday, 18 July 2025 07:23:27 UTC