- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Mon, 07 Jul 2025 20:25:11 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1756/review/2995854648@github.com>
@yoshisatoyanagisawa commented on this pull request. > + 1. If |navigationPreloadResponse|'s [=response/type=] is "`error`", reject |preloadResponse| with a `TypeError` and terminate these substeps. + 1. Associate |preloadResponseObject| with |navigationPreloadResponse|. + 1. Resolve |preloadResponse| with |preloadResponseObject|. + 1. [=If aborted=], then: + 1. Let |deserializedError| be the result of [=deserialize a serialized abort reason=] given null and |workerRealm|. + 1. [=fetch controller/Abort=] |preloadFetchController| with |deserializedError|. + 1. Else if |timingInfo|'s [=service worker timing info/worker matched router source=] is not "{{RouterSourceEnum/fetch-event}}", a user agent may run the following substeps: + + Note: A user agent may speculatively dispatch a network request in parallel with creating a fetch event in order to minimize the bootstrap cost. + + 1. Assert: [=service worker timing info/worker matched router source=] is null. + 1. Let |autoPreloadFetchController| be null. + 1. Set |responseForAutoPreload| to be a [=race response=] whose [=race response/value=] is "<code>pending</code>". + 1. Run the following substeps [=in parallel=], but [=abort when=] |fetchController|'s [=fetch controller/state=] is "<code>terminated</code>" or "<code>aborted</code>": + 1. Set |autoPreloadFetchController| to the result of calling [=fetch=] given |request|, with [=fetch/processResponse=] set to the following steps given a [=/response=] |autoPreloadRequestResponse|: + 1. Set |responseForAutoPreload|'s [=race response/value=] to |autoPreloadRequestResponse|. You may need another indent here? -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1756#pullrequestreview-2995854648 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1756/review/2995854648@github.com>
Received on Tuesday, 8 July 2025 03:25:15 UTC