- From: arai-a <notifications@github.com>
- Date: Wed, 02 Jul 2025 08:04:32 -0700
- To: whatwg/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/webidl/pull/1498@github.com>
Do not throw if the attribute setter is called with no arguments This is for https://github.com/whatwg/webidl/issues/1497 . This changes the attribute setter not to throw if it's called with no arguments (this can happen only if the setter function is extracted from the property descriptor and directly called), and instead treat it as if `undefined` is passed. No browsers had been following the previous behavior, and the updated behavior matches WebKit. - [x] At least two implementers are interested (and none opposed): * WebKit (https://github.com/whatwg/webidl/issues/1497#issuecomment-3019315858) * Chromium (https://github.com/whatwg/webidl/issues/1497#issuecomment-3021612289, https://github.com/whatwg/webidl/issues/1497#issuecomment-3021622854) * Gecko (https://github.com/whatwg/webidl/issues/1497#issuecomment-3028206420 , and patch is ready in https://bugzilla.mozilla.org/show_bug.cgi?id=1974950) - [ ] [Tests](https://github.com/web-platform-tests/wpt) are written and can be reviewed and commented upon at: * The patch part 2 in https://bugzilla.mozilla.org/show_bug.cgi?id=1974950 - [ ] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed: * Chromium: … * Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1974950 * WebKit: (Already matches the updated behavior, and it's passing the WPT added in the above) * Deno: … * Node.js: … * webidl2.js: … * widlparser: … - [ ] [MDN issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed: … - [x] The top of this comment includes a [clear commit message](https://github.com/whatwg/meta/blob/main/COMMITTING.md) to use. <!-- This comment and the below content is programmatically generated. You may add a comma-separated list of anchors you'd like a direct link to below (e.g. #idl-serializers, #idl-sequence): Don't remove this comment or modify anything below this line. If you don't want a preview generated for this pull request, just replace the whole of this comment's content by "no preview" and remove what's below. --> *** <a href="https://whatpr.org/webidl/1498.html" title="Last updated on Jul 2, 2025, 3:04 PM UTC (e9b7e29)">Preview</a> | <a href="https://whatpr.org/webidl/1498/122e9da...e9b7e29.html" title="Last updated on Jul 2, 2025, 3:04 PM UTC (e9b7e29)">Diff</a> You can view, comment on, or merge this pull request online at: https://github.com/whatwg/webidl/pull/1498 -- Commit Summary -- * Do not throw if the attribute setter is called with no arguments -- File Changes -- M index.bs (4) -- Patch Links -- https://github.com/whatwg/webidl/pull/1498.patch https://github.com/whatwg/webidl/pull/1498.diff -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/webidl/pull/1498 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/webidl/pull/1498@github.com>
Received on Wednesday, 2 July 2025 15:06:16 UTC