Re: [w3c/ServiceWorker] Add 1024 as the number of router rule registration limit (PR #1752)

@sisidovski commented on this pull request.



> @@ -3409,6 +3418,9 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
 
           1. If running the [=Verify Router Condition=] algorithm with |condition|["{{RouterCondition/not}}"] and |serviceWorker| returns false, return false.
           1. Set |hasCondition| to true.
+      1. If |hasCondition| is true, then:
+          1. Increament |serviceWorker|'s [=service worker/router rule count=] by one.

Discussed offline. We don't need it anymore.

We have a rough agreement on the new approach, having two limits and validates them in between the step 5 and 6 in addRoutes().
https://w3c.github.io/ServiceWorker/#dom-installevent-addroutes

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1752#discussion_r1936561188
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1752/review/2585499632@github.com>

Received on Friday, 31 January 2025 01:56:00 UTC