Re: [w3c/ServiceWorker] Allow the addRoutes() to be called during installing (PR #1744)

> > The order of route validation might be slightly different after the PR
> 
> This is a minor point really.
> 
> What I am meaning is that, before the PR, we would do:
> 
> * Iterate through the routes to validate them, reject as needed
> * Iterate through the routes to check route source and fetch event, reject as needed.
> 
> With the PR, it does:
> 
> * Iterate through the routes:
>   
>   * If route is not validated, reject
>   * If route source is fetch-event and no fetch event is registered, reject
> 
> In both cases, `TypeError` is used, but the error message is likely different.

Got it.  Yeah, TypeError will be thrown in both cases, but which one to verify first has been changed.  Since this is a specification, the verification order should be mattered.  I had to hone that feeling.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1744#issuecomment-2626114759
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1744/c2626114759@github.com>